Allow installing an executable script pygridsynth#8
Allow installing an executable script pygridsynth#8NnktYoshioka merged 1 commit intoquantum-programming:mainfrom
Conversation
For example, with pip install . or pip install -e .
|
Hello, I am Hiroki Hamaguchi, one of the maintainers of the pygridsynth project. Regarding this PR, may I ask you a question? from .__main__ import mainin init.py, but when I run <frozen runpy>:128: RuntimeWarning: 'pygridsynth.__main__' found in sys.modules after import of package 'pygridsynth', but prior to execution of 'pygridsynth.__main__'; this may result in unpredictable behaviourI think this approach may not be the best, and I would like to improve it. We plan to release a new PyPI version in a few days, so I would like to address this issue before the next deployment. Thank you very much for your time and consideration. |
|
Thank you for pointing this out. Allows python -m pygridsynth ...But the script now fails with I have opened a PR #10 which allows both methods of running the program without errors or warnings. |
|
Ah.. And to clarify the intention. The desired feature is to be able to run pygridsynth like this: Rather than this Hower, my first PR, which was merged, broke the second method. The new PR #10, should support both of them. |
|
Thank you very much for your prompt response and also for creating a new pull request. We truly appreciate your efforts. |
For example, with
pip install .
or
pip install -e .