Blizzard duplicate return removed #360
Merged
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a copy/paste error in uarch detect for Apple blizzard/avalanche uarch - Add comment for A14/M1 and A15/M2 cpufamily
- Add comments for M1 and M2
kimishpatel
reviewed
Dec 30, 2025
| #ifndef CPUFAMILY_ARM_LIGHTNING_THUNDER | ||
| #define CPUFAMILY_ARM_LIGHTNING_THUNDER 0x462504D2 | ||
| #endif | ||
| // A14 / M1 |
Contributor
There was a problem hiding this comment.
why remove these comments?
Contributor
There was a problem hiding this comment.
oh sorry you added comments. lol my bad. looks better
kimishpatel
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy / paste error for blizzard had 2 return statements.
Remove the duplicate return
Fix comments for CPUFAMILY to match what the case/return are for
Fixes #361