gh-138122: Add some screenshots to the profiling.sampling docs #142676
+7,164
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Some thoughts:
- To start, great idea :-)
- Maybe put the images in a folder for organisation?
- Did you optimise the pngs? (For one way to do this see, #139061)
- What do you think about adding an example
tachyon-flamegraph.htmlto_static?
Member
Author
|
All done |
pablogsal
force-pushed
the
tachyon-images
branch
3 times, most recently
from
dd0eb7b to
d5a75fb
Compare
pablogsal
force-pushed
the
tachyon-images
branch
from
d5a75fb to
ba2b258
Compare
Member
|
To fix EPUB: pablogsal#116 |
Member
Author
|
Thanks a lot @hugovk |
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Member
Author
|
Thanks for the review everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142676.org.readthedocs.build/en/142676/library/profiling.sampling.html