write_hex_file: new parameter byte_count #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You need a check for byte_count value at the beginning of that method, and at least add one more unit test to check desired behaviour. I'd like to have 2 tests: for byte_count = 1, and something between 2 and 15 to check that everything works as expected. |
Author
|
added byte_count check and unitests for 1, 13 and 255 byte counts |
Member
|
Thank you @erki1993 - I need to run new tests on different Python versions and then I can merge it. |
Collaborator
|
What stops this from being merged? Things seem work as advertised 👍 |
bialix
added a commit
that referenced
this pull request
Jan 16, 2018
bialix
added a commit
that referenced
this pull request
Jan 16, 2018
Member
|
Merged to master with some minor changes. Thank you for patch. |
pablovillars
added a commit
to pablovillars/intelhex
that referenced
this pull request
Mar 29, 2021
pablovillars
added a commit
to pablovillars/intelhex
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can choose hex data field length