remove N (size of corpus vocabulary) from phrase model formula #5
Open
Alexjmsherman wants to merge 1 commit intopwharrison:masterfrom
Open
remove N (size of corpus vocabulary) from phrase model formula #5Alexjmsherman wants to merge 1 commit intopwharrison:masterfrom
Alexjmsherman wants to merge 1 commit intopwharrison:masterfrom
Conversation
…is not used in gensim implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the gensim documentation (https://radimrehurek.com/gensim/models/phrases.html#id2) for the models.phrases class, the formula for the phase model is from Tomas Mikolov, Ilya Sutskever, Kai Chen, Greg Corrado, and Jeffrey Dean. Distributed Representations of Words and Phrases and their Compositionality. In Proceedings of NIPS, 2013.
In the paper, the equation does not include N (size of the corpus vocabulary) as is listed in your notebook. I updated the equation removing N and it's definition
https://papers.nips.cc/paper/5021-distributed-representations-of-words-and-phrases-and-their-compositionality.pdf
FYI, I saw you present this at PyData D.C. I thought it was a great presentation and still, clearly, refer to this notebook often. Thanks for putting it together.