Stop passing base version when not provided #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggainey
requested changes
Jan 5, 2026
| if base_repository is None: | ||
| base_repository = repo_ctx | ||
| base_version_ctx = base_repository.get_version_context(base_version) | ||
| repo_ctx.modify(add_content=[content_ctx.pulp_href], base_version=base_version_ctx) |
Contributor
There was a problem hiding this comment.
The previous code would use base_repository.get_version_context(-1) if no base-version was passed in - so we'd create a new version in repo_ctx, based on base_repository.latest. This change ignores base_repository unless base_version_ctx is also passed in.
If base_version is None and base_repository is not None then base_version_ctx needs to be base_repository.get_version_context(-1), yeah?
ggainey
approved these changes
Jan 6, 2026
| base_repository = repo_ctx | ||
| base_version_ctx = base_repository.get_version_context(base_version) | ||
| elif base_repository is not None: | ||
| base_version_ctx = base_repository.get_version_context(-1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1290