Conversation
Member
|
I'm fine with this. I also do not have immediately in mind an instance where we have multiple PULP clusters anyways, so I am not sure this works at all anyways... |
FrancescoConti
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to remove the cluster_id information from the core_demux because it is used differently from the other IPs that need it (i.e. cluster_bus_wrap and xbar_pe). Essentially it is recomputing the most significant 12-bits of the pulp_cluster base address ignoring the fact that the offset given by the id is already provided from the outside.
Let me know what you think, this is giving me a bit of urticaria because in general it looks like this cluster_id thing has been developed by different people (working on both hardware and software) who did not communicate much, so it is quite confuring and bothering. Happy to discuss ways to make it cleaner, but for now I am opening this PR.