Make dependency on pmsis optional and add more parameters to Neureka#23
Make dependency on pmsis optional and add more parameters to Neureka#23da-gazzi wants to merge 6 commits intopulp-platform:mainfrom
pmsis optional and add more parameters to Neureka#23Conversation
|
@da-gazzi you are the first fork enjoyer to create a PR to this repo so I had to fix the CI to trigger on pull_requests and not just push. Could you please push whatever to this branch to trigger the CI (hopefully). I think just a will rehash the last commit and trigger it too. |
pmsis optional and add more parameters to Neureka
Thanks! I think it worked, I see new actions :D |
|
@da-gazzi the linting I believe you can solve by yourself, but the test errors I can take upon myself. Either I write the fixes here, maybe if they are not too big, or you give me permission on your fork to commit directly there |
|
Lint errors should be fixed, and Moritz has given you access to his fork - thanks! |
5abcbd2 to
83f8b40
Compare
|
Your changes -> my changes (I edited the first commit and force pushed which made that commit and all further commits mine, honest mistake 👀 ) I think I understand the idea behind making pulp-nnx an INTERFACE, and I agree it would be saner but how we currently add the pulp-sdk dependency to it is a bit jank. Instead of having it as a dependency of the BSP it is actually linked to the pulp-nnx library in the user's CMakeLists.txt (example). Is that good enough for your use case? |
|
Hey Luka, sorry that I dropped the ball on this - the |
|
closing this PR in favor of #26. All the original code preserved + added fixes |
These changes make the
pulp-nnxlibrary more portable:pmsisand the siracusa BSP by making them optional#define's of some architectural parameters are now wrapped in#ifndefso they can be overwritten at compile time