obi_atop_resolver: Add comments and use common_cells assertions#26
Draft
colluca wants to merge 1 commit intoatop-outst-txnsfrom
Draft
obi_atop_resolver: Add comments and use common_cells assertions#26colluca wants to merge 1 commit intoatop-outst-txnsfrom
common_cells assertions#26colluca wants to merge 1 commit intoatop-outst-txnsfrom
Conversation
micprog
requested changes
Jul 25, 2025
Member
micprog
left a comment
micprog
left a comment
There was a problem hiding this comment.
Thanks for adding some more explanations in the atop module. Some minor comments.
Comment on lines
-3
to
+4
| revision: 9afda9abb565971649c2aa0985639c096f351171 | ||
| version: 1.38.0 | ||
| revision: de8742553f36321af3997418cb632907081c273a | ||
| version: null |
Member
There was a problem hiding this comment.
Let's not use a custom common_cells version on the main branch here - please use a proper version tag.
Author
There was a problem hiding this comment.
Waiting on this pulp-platform/common_cells#263 to address that.
colluca
force-pushed
the
comment-atop-resolver
branch
from
4407096 to
1080002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor, non-functional changes to improve code readability and understanding:
MODEparametercommon_cellsassertions for all checks