Conversation
micprog
force-pushed
the
dma
branch
3 times, most recently
from
684ccf1 to
9401d64
Compare
Scheremo
reviewed
Aug 12, 2024
Scheremo
left a comment
Scheremo
left a comment
There was a problem hiding this comment.
Looks pretty decent to me, left some comments and questions.
Comment on lines
+18
to
+21
| parameter int unsigned NarrowDataWidth = 0, | ||
| /// Data Width for the Wide Ports | ||
| parameter int unsigned WideDataWidth = 0, | ||
| /// Latency of downstream memory for |
There was a problem hiding this comment.
NIT: Might be a good idea to also add reasonable defaults here
| /// Data Width for the Wide Ports | ||
| parameter int unsigned WideDataWidth = 0, | ||
| /// Latency of downstream memory for | ||
| parameter int unsigned MemoryLatency = 2, |
There was a problem hiding this comment.
What does this parameter do? Is is functionally relevant?
| for (genvar i = 0; i < 2; i++) begin : gen_rready_convert | ||
| spill_register #( | ||
| .T (obi_a_chan_t ), | ||
| .Bypass ( '0 ) |
There was a problem hiding this comment.
Are these bypasses always necessary? Seems to me they are mostly relevant for timing.
Might be a good idea to extract their existence as a parameter.
Comment on lines
+111
to
+113
| .NumRegs (32'd1), | ||
| .NumStreams (32'd1), | ||
| .IdCounterWidth(32), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.