Fix FIFO delay parameter propagation in HCI#63
Open
DanielKellerM wants to merge 1 commit intomasterfrom
Open
Conversation
DanielKellerM
commented
Aug 25, 2025
Member
|
I gave a look while we were speaking. What I am not super much a fan of is that this is a static information which is "similar" to the min-latency from a given point in the HCI system to memory, but it is not quite that. |
Member
4 tasks
- Propagating FD through the HCI interface makes sure that multi-cycle support is correctly set, and the assertions are checked properly - Adds FD Fifo Depth parameter to package and interfaces - This allows support multiple cycle for HWPE interfaces using the FIFO
0faa4f3 to
a628388
Compare
Member
|
@DanielKellerM: with @sermazz we decided to postpone #61 and #60. So this PR is back on the table, I'll give it a new look in the coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
EXPFIFOparameter inhci_interconnectwould introduce multicycle delays in ther_validsignal, but thehci_core_r_id_filtermodule would trigger incorrect assertions even whenMULTICYCLE_SUPPORTwas active. This created an inconsistency between modules where one parameter was changing what another module should check, without proper parameter propagation.Proposed Solution:
EXPFIFOwithFD(FIFO Depth) parameter: integrated FIFO depth information directly into the HCI package structures for better parameter propagation.FDparameter tohci_size_parameter_tstruct and created helper macros for consistent parameter handling.FDparameter to allhci_core_intfdeclarations throughout the system.FDparameter checks for module port interfaces.These changes are reflected in Neureka's interface: pulp-platform/neureka#36 (comment)