[hardware] add vmv.xs and vfmv.fs in in_lane_op#433
Merged
Navaneeth-KunhiPurayil merged 1 commit intopulp-platform:mainfrom Nov 27, 2025
Merged
[hardware] add vmv.xs and vfmv.fs in in_lane_op#433Navaneeth-KunhiPurayil merged 1 commit intopulp-platform:mainfrom
Navaneeth-KunhiPurayil merged 1 commit intopulp-platform:mainfrom
Conversation
If a vsetvl instruction that changes SEW is placed immediately before vmv.xs, the vmv.xs instruction does not trigger a reshuffle because it is not in the in_lane_op category. This lack of reshuffle leads to vmv.xs writing back an incorrect value.
mp-17
approved these changes
Nov 26, 2025
Contributor
mp-17
left a comment
mp-17
left a comment
There was a problem hiding this comment.
Hi @ESE-2019, thanks for spotting that. LGTM; let's wait for the CI to pass, and then we can merge. @Navaneeth-KunhiPurayil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
good first issue
Changelog
Fixed
Added
Changed
Checklist
Please check our contributing guidelines before opening a Pull Request.