Send new presence state to the SharedWorker and fix newer access token override
#473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue because of which requests aggregated from other clients were able to override previously explicitly set newer access token. feat(presence-state): send new presence `state` to the `SharedWorker` Send new presence `state` to the `SharedWorker` as soon as it has been set with `setState` to avoid race conditions between regular heartbeats and `backup` heartbeats. refactor(shared-worker): exclude presence `state` from long-poll subscribe request Remove presence `state` from long-poll subscribe requests as part of the transition to explicit heartbeat.
parfeon
added
status: done
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
approved these changes
Sep 8, 2025
Contributor
mohitpubnub
left a comment
mohitpubnub
left a comment
There was a problem hiding this comment.
some queries.
overall looks good.
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(shared-worker): fix newer access token override
Fix issue because of which requests aggregated from other clients were able to override previously explicitly set newer access token.
feat(presence-state): send new presence
stateto theSharedWorkerSend new presence
stateto theSharedWorkeras soon as it has been set withsetStateto avoid race conditions between regular heartbeats andbackupheartbeats.refactor(shared-worker): exclude presence
statefrom long-poll subscribe requestRemove presence
statefrom long-poll subscribe requests as part of the transition to explicitheartbeat.