(bug) Instantiate Helm charts before calling chart manager#1608
Merged
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom Feb 11, 2026
Merged
(bug) Instantiate Helm charts before calling chart manager#1608gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
Conversation
Chart manager keeps track of: 1. helm releases (identified by release namespace and release name) are deployed on a given managed cluster 2. which clusterSummary deployed a given Helm release Sveltos allows Helm release namespace and name to be expressed as template. Before invoking any chart manager API, always instantiate the helm chart. Before this PR, Sveltos was passing chart manager a mix of instantiated values and non instantiated values. This caused several problems. The most critical one, on addon-controller restart, Sveltos undeployed certain releases considering those stale.
gianlucam76
force-pushed
the
instantiate-helm-charts
branch
from
67ee1f7 to
3390ef3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart manager keeps track of:
Sveltos allows Helm release namespace and name to be expressed as template. Before invoking any chart manager API, always instantiate the helm chart.
Before this PR, Sveltos was passing chart manager a mix of instantiated values and non instantiated values. This caused several problems. The most critical one, on addon-controller restart, Sveltos undeployed certain releases considering those stale.
Fixes #1609