fix(SelfSubjectReview): authorization for ns #919
+224
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
|
Any update on this ? It looks 100% implemented |
Author
|
Everything is working in k9s as far as I know it's just waiting for a review |
prometherion
approved these changes
Dec 29, 2025
Member
prometherion
left a comment
prometherion
left a comment
There was a problem hiding this comment.
LGTM, I think this will unlock also supports for Headlamp.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
internal/webserver/webserver.go
Outdated
|
|
||
| scheme := runtime.NewScheme() | ||
| protoEncoder := protobuf.NewSerializer(scheme, scheme) | ||
| corev1.AddToScheme(scheme) |
Check warning
Code scanning / gosec
Errors unhandled Warning
internal/webserver/webserver.go
Outdated
| scheme := runtime.NewScheme() | ||
| protoEncoder := protobuf.NewSerializer(scheme, scheme) | ||
| corev1.AddToScheme(scheme) | ||
| authorizationv1.AddToScheme(scheme) |
Check warning
Code scanning / gosec
Errors unhandled Warning
internal/webserver/webserver.go
Outdated
| } | ||
| } | ||
| writer.WriteHeader(w.Result().StatusCode) | ||
| writer.Write(body) |
Check warning
Code scanning / gosec
Errors unhandled Warning
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1666 by mutating the selfsubjectaccessreviews and selfsubjectrulesreviews for the namespaces