-
Notifications
You must be signed in to change notification settings - Fork 4
Add support to Thread commissioning #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.15-cli-develop
Are you sure you want to change the base?
Add support to Thread commissioning #64
Conversation
Summary of ChangesHello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational support for Thread commissioning by extending the available device pairing modes. This enhancement allows the system to recognize and handle devices using Thread for their initial setup, aligning with ongoing development efforts to broaden connectivity options. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for 'thread' as a DUT pairing mode by adding a new enum member. While the code change is correct, it is made in a file that is explicitly marked as a copy that should not be edited directly. My review includes a comment highlighting this maintainability issue, suggesting the change be made in the original source file to prevent it from being accidentally overwritten.
antonio-amjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need a way to remove the copy of shared_contants.py from CLI so we don't need to update this side (I don't know how). It will work even without this change since CLI install script will copy from backend.
Approving either way.
Add support to Thread commissioning
Related issue: project-chip/certification-tool#869