documentation of amplitude.disconnect() method in p5.js-sound library#5866
documentation of amplitude.disconnect() method in p5.js-sound library#5866Nitesh639 wants to merge 1 commit intoprocessing:mainfrom Nitesh639:main
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
I think we want to make your change first in your other PR processing/p5.js-sound#682 since the p5.sound library in this repository is, I think, just a compiled version of that library. (@Qianqianye, is my understanding of that correct? Is there a process for updating it?) I'm going to re-open your PR there first, and then once that's done and merged, I'll figure out what needs to be done to mirror that here! |
|
@davepagurek ok, I will do it. If it's required. |
|
Yes, changes to the p5.Sound library should be made in the p5.Sound repo and it will be copied over when p5.Sound wants to create a new release. Thanks. |
Resolves: Documentation of amplitude.disconnect() method with example in p5.js-sound library
Changes: lib/addons/p5.sound.js
Screenshots of the change:


PR Checklist
npm run lintpasses