Fix broken webplatform.org links for AudioParam#937
Closed
md5 wants to merge 1 commit intoprocessing:mainfrom
Closed
Fix broken webplatform.org links for AudioParam#937md5 wants to merge 1 commit intoprocessing:mainfrom
md5 wants to merge 1 commit intoprocessing:mainfrom
Conversation
perminder-17
requested changes
Aug 18, 2025
Contributor
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Hi @md5, thanks a lot for catching all these broken links and for fixing them. The only issue is that the p5.Sound docs are auto-generated from the p5.sound repo. So the best approach would be to make the changes directly in that repo instead. What you think?
Author
|
Closed in favor of processing/p5.js-sound#808 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there were a number of broken links to documentation for
AudioParamin thep5.sounddocs, pointing to the defunct wiki on webplatform.org. This PR updates to point to theAudioParamdocs in the Web Audio spec instead.There was an additional reference to the broken URL in
public/reference/data.json, but it seems like that might be a generated file. I can update that reference as well if that's necessary or desirable.