Fix missing p5. prefix in Simple Melody App tutorial#1124
Open
aashu2006 wants to merge 2 commits intoprocessing:mainfrom
Open
Fix missing p5. prefix in Simple Melody App tutorial#1124aashu2006 wants to merge 2 commits intoprocessing:mainfrom
aashu2006 wants to merge 2 commits intoprocessing:mainfrom
Conversation
Fixes a ReferenceError in the simple-melody-app tutorial where Oscillator was used without the p5 namespace, causing the example to fail at runtime.
Contributor
Author
|
Hi, @ksen0. I have updated the PR with the link cleanup and the typo fix, and added the oscillator fix as well. Everything should be good now, thanks for the guidance! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small bug in the Simple Melody App tutorial and cleans up a few old links.
What changed
Fixed a broken line in the tutorial by changing
new Oscillator()tonew p5.Oscillator().Without this, the code throws an error and the tutorial can’t be completed.
Replaced some old Google Docs links with proper internal links inside the site.
simple-melody-app.mdx,optimizing-webgl-sketches.mdx,getting-started-with-nodejs.mdxFixed a typo in a section heading (
osciallators→oscillators) and updated the related link.Testing
new p5.Oscillator()works in the p5.js Web Editornew Oscillator()line throws an error