fix: multiple small documentation issues across tutorials and reference#1060
Conversation
94eb1bb to
50333a9
Compare
50333a9 to
5e82f3b
Compare
|
yes, you’re right. i found the root cause, in RootPage layout the explicit h-[50vh] on the parent div makes the container behave like it has a fixed height, so the content overflows at certain sizes.
re: contributor docs, i didn’t know they get overwritten from the p5.js repo. i’ve removed the broken link commit from here. |
|
Great, those screenshots look good! Thanks for testing out the build process too. This likely means that we need to edit the script that converts those contributor docs pages to mdx files in https://github.com/processing/p5.js-website/blob/main/src/scripts/builders/contribute.ts to make it not add a trailing slash on that link. I havent looked deeply into how it works currently, so it would be great to investigate what its logic currently is so we can see how to change it (should the trailing slash only apply to p5 site links, and be omitted everywhere else?) |
|
@davepagurek i looked into the contributor-docs build and found where the trailing slash is being added. it comes from the right behavior would be to apply the trailing-slash normalization only to internal p5 site links, and skip rewriting entirely for external URLs (http(s), mailto, protocol-relative). |
davepagurek
left a comment
There was a problem hiding this comment.
Looks good, thanks! Mind making a PR with these changes into the 2.0 branch too?




resolves #1057
fixes several small documentation issues found while going through the p5.js docs and tutorials.
changes
fix incorrect height value in conditionals-and-interactivity tutorial.
fix "Filter by keyword" input overlapping text.
replace loop length with segments and declare move in repeating-with-loops tutorial.
all changes are documentation-only and independent.
the Google Color Picker link is not fixed yet, it’ll be replaced based on maintainers preference.