Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughMultiple fumadocs library dependencies are bumped to versions 16.6.1 and 10.3.5 across package files. Type definitions in the docs layout component are refactored to use single-quoted string literals consistently. Marketing URLs are updated with new utm parameters. Changes
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🍈 Lychee Link Check Report3660 links: ❌ Errors
Full Statistics Table
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/docs/src/lib/layout.shared.tsx (1)
59-59:⚠️ Potential issue | 🟡 MinorPre-existing typo: "Managment" → "Management".
While not part of this diff, since this is a docs chore PR and you're already in the file, might be a nice quick win to fix.
- { text: 'Managment API', url: '/management-api', active: 'nested-url' }, + { text: 'Management API', url: '/management-api', active: 'nested-url' },
🤖 Fix all issues with AI agents
In `@apps/docs/src/components/layout/notebook/index.tsx`:
- Line 344: The navbar currently renders <ThemeToggle mode={themeSwitch.mode ??
'light-dark-system'} /> unconditionally; change it to honor the same guard used
in the sidebar (check themeSwitch.enabled !== false) so the toggle is only
rendered when enabled, or explicitly document/intentionally always show it if
that behavior is desired — update the conditional around the ThemeToggle in the
notebook component to reference themeSwitch.enabled (or themeSwitch?.enabled)
and keep the existing mode fallback.
🧹 Nitpick comments (1)
apps/docs/src/components/layout/notebook/index.tsx (1)
320-324: Commented-out i18n toggle — intentional?This block is commented out rather than removed. If it's a temporary measure while the i18n feature is being reworked, a brief
// TODO:comment explaining the intent would help future readers understand why it's here rather than deleted.
| ))} | ||
| </div> | ||
|
|
||
| <ThemeToggle mode={themeSwitch.mode ?? 'light-dark-system'} /> |
There was a problem hiding this comment.
ThemeToggle is now rendered unconditionally.
Previously in the sidebar drawer (line 231-233), the theme toggle is guarded by themeSwitch.enabled !== false. Here in the navbar, the ThemeToggle renders regardless of the themeSwitch.enabled prop. If a consumer passes themeSwitch: { enabled: false }, they'd still see a toggle in the navbar — which may not be the intended behavior.
If this is deliberate (e.g., "always show toggle in navbar"), that's fine. Otherwise:
- <ThemeToggle mode={themeSwitch.mode ?? 'light-dark-system'} />
+ {themeSwitch.enabled !== false && (
+ <ThemeToggle mode={themeSwitch.mode ?? 'light-dark-system'} />
+ )}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <ThemeToggle mode={themeSwitch.mode ?? 'light-dark-system'} /> | |
| {themeSwitch.enabled !== false && ( | |
| <ThemeToggle mode={themeSwitch.mode ?? 'light-dark-system'} /> | |
| )} |
🤖 Prompt for AI Agents
In `@apps/docs/src/components/layout/notebook/index.tsx` at line 344, The navbar
currently renders <ThemeToggle mode={themeSwitch.mode ?? 'light-dark-system'} />
unconditionally; change it to honor the same guard used in the sidebar (check
themeSwitch.enabled !== false) so the toggle is only rendered when enabled, or
explicitly document/intentionally always show it if that behavior is desired —
update the conditional around the ThemeToggle in the notebook component to
reference themeSwitch.enabled (or themeSwitch?.enabled) and keep the existing
mode fallback.
Summary by CodeRabbit
New Features
Chores