-
Notifications
You must be signed in to change notification settings - Fork 129
Generate unique labels for all form control inputs #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Generate unique labels for all form control inputs #3899
Conversation
🦋 Changeset detectedLatest commit: 9a6c6cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses an accessibility issue where form control inputs in preview files shared the same hardcoded ID ("bar"), causing screen readers to announce all labels simultaneously when focusing the first input. The fix generates unique IDs using SecureRandom.hex to ensure proper label-to-input association and correct screen reader announcements.
Changes:
- Generate unique field IDs dynamically using
SecureRandom.hex(6)for each form control preview instance - Update both the
label_argumentsand inputidto use the generated unique ID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Clarified the description of label generation for form controls in previews.
…ement-fix' of github.com:primer/view_components into llastflowers/14752/formcontrol-preview-label-sr-announcement-fix
…-sr-announcement-fix
…ement-fix' of github.com:primer/view_components into llastflowers/14752/formcontrol-preview-label-sr-announcement-fix
…-sr-announcement-fix
What are you trying to accomplish?
Integration
N/A
List the issues that this change affects.
Addresses https://github.com/github/accessibility-audits/issues/14752
Risk Assessment
What approach did you choose and why?
The labels were all being announced at once when the first input was focused, because the inputs all had the same id which broke the label association. The other input labels were also not being announced. This updates the previews so that unique labels are generated for each input, addressing the SR announcement issues.
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
Fix for a11y audit remediation issue
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.