Skip to content

Conversation

@TylerJDev
Copy link
Member

Overview

This pull request adds the Playwright MCP testing skill and detailed instructions for using it in the primer/view_components repository.

Changes

  • Added Playwright MCP configuration in .copilot/mcp.json
  • Created guidance documentation in .github/agents/playwright-testing.md
  • Updated Copilot instructions in .github/copilot-instructions.md

Benefits

This integration will help developers verify visual and accessibility aspects of UI components efficiently.

@TylerJDev TylerJDev requested a review from a team as a code owner January 26, 2026 18:14
@TylerJDev TylerJDev requested review from Copilot and jonrohan January 26, 2026 18:14
@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 587e76e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Playwright MCP configuration and repository guidance so contributors can use Playwright (including screenshots and ARIA snapshots) to validate UI and accessibility changes in primer/view_components.

Changes:

  • Added Playwright MCP server configuration under .copilot/mcp.json.
  • Added a Playwright MCP usage guide at .github/agents/playwright-testing.md.
  • Added Copilot contribution/testing guidance in .github/copilot-instructions.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/copilot-instructions.md Documents repo UI testing context and points contributors to the Playwright MCP guide.
.github/agents/playwright-testing.md Provides step-by-step Playwright MCP testing guidance (demo app, preview URLs, themes, snapshots).
.copilot/mcp.json Configures the Playwright MCP server invocation via npx.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +6
"command": "npx",
"args": ["@playwright/mcp@latest"],
"type": "stdio"
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npx may prompt for confirmation when executing a package that isn’t installed locally (npm 7+), which can cause the MCP server startup to hang. Consider adding the appropriate non-interactive flag (e.g., --yes) or invoking a locally installed binary instead.

Copilot uses AI. Check for mistakes.
"mcpServers": {
"playwright": {
"command": "npx",
"args": ["@playwright/mcp@latest"],
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @playwright/mcp@latest makes the MCP server version non-deterministic and can break unexpectedly (or pull in compromised releases). Consider pinning to a specific version (and updating deliberately), and/or adding it as a devDependency so it’s covered by the lockfile instead of fetching from the network at runtime.

Suggested change
"args": ["@playwright/mcp@latest"],
"args": ["@playwright/mcp@0.0.6"],

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants