Allow setting of direct_samp via init args#65
Open
ryansuchocki wants to merge 1 commit intopothosware:masterfrom
Open
Allow setting of direct_samp via init args#65ryansuchocki wants to merge 1 commit intopothosware:masterfrom
ryansuchocki wants to merge 1 commit intopothosware:masterfrom
Conversation
Member
|
I see the point. It would be preferable however if GQRX could be changed to enumerate Settings and offer a UI for them or at least offer free-form input for Settings. Any chance for that? |
Author
|
OK, I'll look into that. My initial observation is that gr-osmosdr (which GQRX uses) doesn't make any calls to |
|
An other way would be to replace gr-osmosdr witch is no very maintened by gr-soapy. My Feature request here: gqrx-sdr/gqrx#1267 |
|
Than you should also update the response of get_full_frequency_range it is now returning a minimum of 24 Mhz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct sampling mode can currently only be set via
writeSetting(). This adds the option of setting it upon initialisation.In turn, this allows a user to trigger the mode from a client such as GQRX which has no specific support for writing settings but does allow a free-form device argument string.