Deprecated numpy function and consistent IQ data#8
Open
30hours wants to merge 3 commits intopolygon:masterfrom
Open
Deprecated numpy function and consistent IQ data#830hours wants to merge 3 commits intopolygon:masterfrom
30hours wants to merge 3 commits intopolygon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit removes the numpy tostring() function deprecated in 1.19.0 (currently at 1.26.4 on PyPi). The replacement is tobytes().
The second commit adds a seed when generating random phases. This is so any image produces identical IQ data when the program is re-run. My application is in a capture the flag where having consistent IQ data is important.