Conversation
Contributor
Author
|
@talentlessguy any idea on how I can fix the tests on this to merge? I am not a TS person so the error message on the ci is a bit cryptic to me, though I'm happy to learn with a little guidance |
v1rtl
reviewed
Jun 23, 2023
Member
|
I added JSDoc comments for the effect's parameters. Are these accurate? I'll want to mirror this in documentation. |
Contributor
Author
|
Thanks @CodyJasonBennett for fixing the types! left a few comments/suggestions. |
|
🎉 This PR is included in version 2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ramp effect for linear and radial color gradients, as well as masking of effects before it in the effect array
Example: https://codesandbox.io/s/ramp-effect-w-postprocessing-zdpzei?file=/src/Ramp.js:0-3359