Add tip for handling middle URL parameters#17
Open
joeySchentrup wants to merge 1 commit intopmjones:2.xfrom
Open
Add tip for handling middle URL parameters#17joeySchentrup wants to merge 1 commit intopmjones:2.xfrom
joeySchentrup wants to merge 1 commit intopmjones:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This in reference to this issue: #16
After doing some prototyping and thinking, I don't think this is a bug but a good design choice. Not allowing implicit url parameters makes the location of the parameter in the url clearer. If subdirectories were able to declare url parameters in the url earlier than their location in the url, the location of the path variable then could vary.
For example, for the class
If there was no subclass
Project\Http\Photo\GetPhoto, we would not know if$photoIDwas hereGET /photo/$photoID/editorGET /photo/edit/$photoIDor both. Seems like a bad trade off.Therefore, this PR is just a readme update to make it more clean the "parent" class is required if using an in the middle path variable.