fix resolve of protolint.path if configured relative#36
fix resolve of protolint.path if configured relative#36yrtimiD wants to merge 1 commit intoplexsystems:masterfrom
Conversation
|
@yrtimiD Hello, could you describe a scenario where the relative path makes sense? Maybe accepting just an absolute path is better? |
|
In my specific case I wanted to keep protolint binary committed to the git, so its location will always be relative to the vscode workspace folder. This is not super right, but saves from everybody extra step of download and install the binary. Alternatively, configuration might allow using vscode's variables like |
|
The relative path would be extremely useful if you have protolint installed via npm. In my case I tried to...
This way anyone on my team who runs |
|
I would really appreciate if these changes were considered 🙏 |
Fixes relative path usage which was resolved to the user folder (~), (very unexpected behavior)
This fix allows 3 cases for protolint.path config:
protolint(used as-is)Added settings caching.
Added settings reload only if changed.