Fix: Preserve submit button value in form submissions with custom events#5900
Fix: Preserve submit button value in form submissions with custom events#5900iraprabhu05 wants to merge 10 commits intoplausible:masterfrom
Conversation
|
Hi, bringing this up in case it got missed. The checks are still awaiting approval and I’m happy to make any required updates. |
|
Hey! Sorry about the wait. This has been a long-standing bug in our tracker and I'm glad you've proposed a fix. Thank you! 🙏 The tracker code has pretty extensive test coverage and this feels like something that should be tested as well. To move forward there's 2 options:
|
|
Hi! I’ve added the test you requested. It verifies that the submit button’s value is preserved when forms are submitted with custom events, and confirms that the expected payload includes the correct provider value. Everything now aligns with the expected behavior from the issue. Happy to update anything further if needed, and thank you for the clear feedback! |
|
@iraprabhu05 I've approved the workflows. The test is failing and there's a formatting issue |
Changes
Fixes incorrect event name parsing in
custom-events.jsfor issue #5050.Added proper handling so custom events trigger correctly with updated tracking logic.
Tests
Changelog
Documentation
Dark mode