You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My only concern is with existing users. Their existing UUID columns will still use the uuid extension. I think our options are:
Leave extensions = ("uuid-ossp",), for now
Write something in the docs about it - so users can manually set the extensions value, or we could provide some kind of migration script for converting existing columns
Make Piccolo auto migrations understand this change, but this might be tricky
I think we can safely make this transition because the generated UUID is identical from both functions. I think we are also safe with older migrations because we don't use hard-coded values (e.g in the migration we use the UUID4 class, not gen_random_uuid() or uuid_generate_v4()). If we used these hard-coded values, the user would have to change them in every older migration, which is not the case. I tried generating the UUID PK using the extension and then I change to gen_random_uuid() and was able to use the existing records with the extension generated UUID and everything was fine. I'm sorry if I'm wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1309