Skip to content

fix: hover listeners affecting inline editing #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
Jan 9, 2026
Merged

fix: hover listeners affecting inline editing #2570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/LiveDevelopment/BrowserScripts/RemoteFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,14 @@ function RemoteFunctions(config = {}) {
}

function enableHoverListeners() {
// don't enable hover listeners if user is currently editing an element
// this was added to fix a specific bug:
// lets say user double clicked an element: so as soon as the first click is made,
// 'breiflyDisableHoverListeners' is called which has a timer to re-enable hover listeners,
// because of which even during editing the hover listeners were working
if (SHARED_STATE._currentlyEditingElement) {
return;
}
if (config.mode === 'edit' && shouldShowHighlightOnHover()) {
disableHoverListeners();
window.document.addEventListener("mouseover", onElementHover);
Expand Down
Loading