Remove PostgreSQL 12 support.#95
Merged
dwsteele merged 2 commits intopgaudit:integrationfrom May 22, 2025
Merged
Conversation
pgguru
approved these changes
May 22, 2025
Collaborator
pgguru
left a comment
pgguru
left a comment
There was a problem hiding this comment.
Cleanup looks sane; I assume 18 will be added atop this change at some point in the near future?
Collaborator
Author
Yes -- we already have PR #91 for that but I wanted to get this cleanup work done before adding PG18 support and bumping the version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we removed support for PostgreSQL 9.4-11 I rolled up the changes in compatibility.h into the PostgreSQL 12 section. This worked but left cruft laying around that really should have been cleaned up.
This time the contents of the PostgreSQL 12 compatibility section have been merged into the code where all supported versions use the same macro. This causes some short term churn but in the long term should make the code more maintainable.