Add expectDownload() and expectDownloads() methods#196
Open
pascalbaljet wants to merge 10 commits intopestphp:4.xfrom
Open
Add expectDownload() and expectDownloads() methods#196pascalbaljet wants to merge 10 commits intopestphp:4.xfrom
expectDownload() and expectDownloads() methods#196pascalbaljet wants to merge 10 commits intopestphp:4.xfrom
Conversation
Member
|
Does jest or vitest have an API for this? |
Author
From what I found, neither Jest or Vitest support this out of the box. With Dusk, I used a custom browser instance that configures the download behavior via Chrome DevTools: $devTools = new \Facebook\WebDriver\Chrome\ChromeDevToolsDriver($this->driver);
$devTools->execute('Browser.setDownloadBehavior', [
'behavior' => 'allow',
'downloadPath' => $path,
]);I mostly followed Playwright's approach: https://playwright.dev/docs/api/class-download |
Member
|
can you add docs? |
Member
|
fix tests also. |
Author
|
I'm not sure why it didn't fail in CI on my fork, but I removed the dependency on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for capturing and asserting file downloads.
The
Downloadobject supports fluent chaining:You can also access download details directly: