Open
Conversation
gtg-bantonio
changed the title
gtg-bantonio
force-pushed
the
4.x
branch
2 times, most recently
from
bca58a0 to
3f615c2
Compare
|
Just encountered the multipart form issue myself and can confirm this fixes it. In case its useful for the maintainers, I've just pushed up a repo demonstrating the issue: https://github.com/duncanmcclean/pestphp-formdata-bug (I haven't tested the file uploads side though!) |
|
I have faced the same issue and this PR fixes it. Hopefully it can be merged. |
# Conflicts: # src/Drivers/LaravelHttpServer.php # tests/Unit/Drivers/Laravel/LaravelHttpServerTest.php
- Removed the multibyte management for the strings, because with empty PDFs and DOCX does not find the boundary string correctly.
- Remove the temp name if the file has an error. - Standardized the name with the PHP conventions.
- Converted the non-selected files into nulls.
|
@gtg-bantonio any idea why this PR was closed? It seemed to solve a real issue. |
Author
|
@akulmehta Sorry, my bad, I was updating the branch to keep it up with the last changes |
|
@gtg-bantonio no apologies needed. I really want this to be merged - thank you for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.