Allow to limit interactions within a scope#164
Open
mateusjunges wants to merge 9 commits intopestphp:4.xfrom
Open
Allow to limit interactions within a scope#164mateusjunges wants to merge 9 commits intopestphp:4.xfrom
within a scope#164mateusjunges wants to merge 9 commits intopestphp:4.xfrom
Conversation
Contributor
Author
|
Sad to see this sitting idle for 2 months without any review 🙁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is another stab at #155, and it adds a new
within()method to the Webpage class that allows scoping browser interactions to specific CSS selectors.More details
I see that the first PR got reverted because it made the
Webpagenon-readonly. I copied the tests from my previous PR and reworked the implementation.I changed the return type on the
InteractWithElements,MakesElementAssertionsandMakesConsoleAssertionsfromWebpagetoself, as this those traits are now also used on theScopedWepageclass.The new
ScopedWebpagenow keeps context of the scope, so no changes to theWebpageare required.