Closed
Conversation
speeddragon
commented
Nov 18, 2025
Comment on lines
+215
to
+220
| NewOpts = maps:update_with( | ||
| current_redirects, | ||
| fun (Value) -> Value + 1 end, | ||
| 1, | ||
| Opts | ||
| ), |
Author
There was a problem hiding this comment.
I'm not sure if this is the right way to keep track of how many redirects we had, but to do it in another way, I would have to change the code more deeply.
Author
|
Thanks! After reviewing the code, it appears to be better implemented than this PR. I will close this (but keep the branch for now, in case I need this code for testing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal for this functionality is to provide the gun HTTP client with the following redirect functionality, we might in some requests.
This is disabled by default and can be enabled by setting
follow_redirectsto true.or via a config flat file:
For testing, I used the mock server in this PR.
Actions