Open
Conversation
Collaborator
|
Thanks for this @jfrain99 . What is the effect size of the improvement here please? I think we might be better off just thinking through how we can set the device key in a much more efficient way on the normal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
hb_ao:getwith{as, Device, Msg}makes an expensive call tohb_ao:set. In multiple places, we are making multiple of these types of calls in a row, making duplicate expensive requests. Introduceshb_ao:get_many, which takes multiple paths/defaults and only makes one call tohb_ao:set