Skip to content

remove 'tester' from the code, add for test suite run #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ylebre merged 1 commit into from
Jun 6, 2025
Merged

remove 'tester' from the code, add for test suite run #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ php console.php app:enable solid
php console.php config:system:set trusted_domains 1 --value=server
php console.php config:system:set trusted_domains 2 --value=nextcloud.local
php console.php config:system:set trusted_domains 3 --value=thirdparty
# set 'tester' and 'https://tester' as allowed clients for the test suite to run
php console.php user:setting alice solid allowedClients '["f5d1278e8109edd94e1e4197e04873b9", "2e5cddcf0f663544e98982931e6cc5a6"]'
echo configured
6 changes: 0 additions & 6 deletions solid/lib/Controller/ServerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,12 +255,6 @@ public function authorize() {

private function checkApproval($clientId) {
$allowedClients = $this->config->getAllowedClients($this->userId);
if ($clientId == md5("tester")) { // FIXME: Double check that this is not a security issue; It is only here to help the test suite;
return \Pdsinterop\Solid\Auth\Enum\Authorization::APPROVED;
}
if ($clientId == md5("https://tester")) { // FIXME: Double check that this is not a security issue; It is only here to help the test suite;
return \Pdsinterop\Solid\Auth\Enum\Authorization::APPROVED;
}
if (in_array($clientId, $allowedClients)) {
return \Pdsinterop\Solid\Auth\Enum\Authorization::APPROVED;
} else {
Expand Down