Skip to content

Conversation

@glazrtom
Copy link
Contributor

As asked in #170 here is the updated version with github pages. Thanks!

@gemini-code-assist
Copy link

Summary of Changes

Hello @glazrtom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue by updating the URL for the 'Conventional Gitmoji' resource. The change ensures that all references, both in documentation and the plugin's internal configuration, point to the correct and active GitHub Pages hosted version of the Conventional Gitmoji specification, improving user experience and maintaining data integrity.

Highlights

  • Conventional Gitmoji URL Update: The web address for 'Conventional Gitmoji' has been updated from "https://conventional-gitmoji.web.app/" to "https://ackeecz.github.io/conventional-gitmoji/".
  • Documentation Alignment: The updated URL is reflected in both the main README.md file and the custom_gitmojis.md documentation.
  • Source Code Configuration: The tooltipUrl within the ConventionalGitmoji source type in GitmojiSourceType.kt has been updated to point to the new GitHub Pages address.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates a dead link for the Conventional Gitmoji website across documentation and source code. The change is straightforward and effective. I've added one suggestion to improve maintainability in the Kotlin source file by using constants for URLs, following a pattern already present in the file. Overall, this is a good contribution.

override val jsonUrl: String = "https://raw.githubusercontent.com/glazrtom/conventional-gitmoji-config/refs/heads/master/gitmojis.json"
override val localizationUrl: String = "https://raw.githubusercontent.com/glazrtom/conventional-gitmoji-config/refs/heads/master/localizations/gitmojis-{locale}.yaml"
override val tooltipUrl: String = "https://conventional-gitmoji.web.app/"
override val tooltipUrl: String = "https://ackeecz.github.io/conventional-gitmoji/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change is correct, for better maintainability and consistency with other parts of this file (like the Custom object), consider defining this URL and the other related URLs (jsonUrl, localizationUrl) as const val in a companion object within ConventionalGitmoji. This would centralize the URLs and make them easier to manage.

@patou
Copy link
Owner

patou commented Dec 15, 2025

The previous URL https://conventional-gitmoji.web.app/ is more understandable than the new url on github page.
You can add a github action for deployment on firebase hosting, or use a custom domain on github pages.
If you want a more visibilité for this alternative, I thinks a better domain url must be important.

@glazrtom
Copy link
Contributor Author

That would require owning a custom domain. The current one is the default domain provided by GitHub. The previous domain I used was actually intended only for development or non-production use, which I wasn’t aware of at the time.

I think using this domain with a path is effectively the same in terms of clarity. Since users only click the link from within the plugin, they don’t need to read or interpret the URL at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants