Allow constant associated empty root value.#77
Open
cheme wants to merge 2 commits intoparitytech:masterfrom
Open
Allow constant associated empty root value.#77cheme wants to merge 2 commits intoparitytech:masterfrom
cheme wants to merge 2 commits intoparitytech:masterfrom
Conversation
|
Is this for domain separation in the hash? |
Contributor
Author
|
I am not sure about what you mean by "domain separation in the hash", but I it is probably not, it is just to avoid this kind of code https://github.com/paritytech/substrate/blob/faf608eeeda0031629f7608321c7ab41fac6024f/primitives/trie/src/lib.rs#L217 in substrate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new trait
HasherNullEmptyRootthat keep trace of an associated null value for an empty type.A new trait is used because this only makes sense if we assumes that the codec use in the trie will encode node to [0] (this is a bit fishy but rather straightforward solution).
Another memory db is implemented that uses this trait to avoid having to calculate the empty trie root (this happens a lot in substrate).
The implementation is generated from a macro and I am not very happy with the result, but again did not find any good and simple way to implement that, suggestions are very welcome.
Not that in the macro I did ommit an indentation on purpose to keep the diff readable, it should be added before merging, also did not do crate versioning update.