Make hash-db always a no_std library#229
Open
aleasims wants to merge 1 commit intoparitytech:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
stdfeature fromhash-dbcrate, making it always ano_stdlibrary.Motivation
There is nothing in
hash-dbcrate which actually depends onstditems not present incore. So it makes no sense to have this Cargo feature there. Instead it can simply always be ano_stdcrate.Note
I think with these changes trait
MaybeDebugdoesn't make any sense and can be removed completely. In fact there is probably no need to put it as a bound onHasher::Out, because it has nothing to do with caching. I case of implementing something Debug-related, explicit boundHasher::Out: Debugcould be used.