TrieDBMutBase added: no commit on drop#226
Merged
michalkucharczyk merged 10 commits intomasterfrom Dec 8, 2025
Merged
Conversation
lexnv
reviewed
Sep 23, 2025
| [package] | ||
| name = "trie-db" | ||
| version = "0.30.0" | ||
| version = "0.31.0" |
Contributor
There was a problem hiding this comment.
nit: I generally prefer having a dedicated "chore" release PR with no/minimal changes, we'll also need to add this PR to the trie-db changelog 🤔
Contributor
Author
There was a problem hiding this comment.
well, just copied the "modus operandi" from some other commit in this repo :), which makes a change and bumps version.
Contributor
There was a problem hiding this comment.
I think that works too, proly need a few more bumps? 🤔
Contributor
Author
lexnv
reviewed
Sep 23, 2025
lexnv
reviewed
Sep 23, 2025
lexnv
reviewed
Sep 23, 2025
lexnv
approved these changes
Sep 23, 2025
Contributor
lexnv
left a comment
There was a problem hiding this comment.
LGTM! I think we can add the release to a dedicated PR and tiny question around the root ++ commit op 🙏
alexggh
reviewed
Sep 24, 2025
alexggh
approved these changes
Nov 13, 2025
skunert
approved these changes
Nov 17, 2025
bkchr
reviewed
Dec 8, 2025
bkchr
reviewed
Dec 8, 2025
bkchr
approved these changes
Dec 8, 2025
Member
bkchr
left a comment
There was a problem hiding this comment.
Some nitpicks. Otherwise should be fine as it doesn't change the default behavior.
Contributor
Author
|
Uploaded crates: New tags: |
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Dec 11, 2025
This PR bumps trie-db version to `0.31.0` (see paritytech/trie#226)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to prevent
TrieDBMutfrom committing implicitly on drop.This PR extends the
TrieDBMutimplementation to provide better control over when changes are committed to the database.Changes:
commit_on_dropflag added toTrieDBMut,without_commit_on_dropmethod toTrieDBMutBuilderwhich configures the builder to create a non-commitingTrieDBMutinstance for cases where commit on drop is undesired.Part of: paritytech/polkadot-sdk#6020