Allow consuming iterator when decoding compact proof.#135
Open
cheme wants to merge 2 commits intoparitytech:masterfrom
Open
Allow consuming iterator when decoding compact proof.#135cheme wants to merge 2 commits intoparitytech:masterfrom
cheme wants to merge 2 commits intoparitytech:masterfrom
Conversation
bkchr
approved these changes
Jun 18, 2021
Member
bkchr
left a comment
There was a problem hiding this comment.
I realized this will probably not bring that much, but yeah looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cumulus, decoding involve *2 size of proof memory usage from pvf during decoding.
This PR switch trie_codec to allow consuming iterator : see
decode_compact_from_iter_ownedthat will allowus to do iteraton on storage proof in a consuming way with cumulus.
Something like
Note that there will always be a time when we got twice the memory of a single node, but that is the same for any storage read.
cc\ @bkchr