Conversation
The elastic-array crate is a fine piece of software but it'd be good to prefer crates that are commonly used in the ecosystem and likely to be well maintained. smallvec is at v1.0 and generally well-regarded. Related PRs: - [parity-common #282](paritytech/parity-common#282) – [trie-db #46](paritytech/trie#46)
ordian
left a comment
There was a problem hiding this comment.
Looks good, just minor grumbles
|
|
||
| [target.'cfg(target_os = "windows")'.dependencies] | ||
| winapi = "0.3.8" | ||
| winapi = { version = "0.3.8", features = ["heapapi"] } |
There was a problem hiding this comment.
so it didn't work before on windows?
There was a problem hiding this comment.
I honestly don't know how it could have worked; looks like the winapi went completely crazy with features at some point and didn't care much for semver.
The risks of updating dependencies with cargo upgrade...
Co-Authored-By: Andronik Ordian <write@reusable.software>
|
@cheme I think it'd be good to have a somewhat coordinated release of |
|
I think we should include paritytech/trie#46 and paritytech/trie#39. I would also like to have paritytech/trie#45, but I did not find time to review it (but it can be released later). |
Sounds good. Also: we'd need a 👍 on this PR to proceed. :) |
* master: Replace ElasticArray with SmallVec (#282)
The
elastic-arraycrate is a fine piece of software but it'd be good to prefer crates that are commonly used in the ecosystem and likely to be well maintained.smallvecis at v1.0 and generally well-regarded.Unfortunately as
DBValueis part of the public API ofkvdb, this is a breaking change so changing this implies annoying busy-work in consuming code.