GH1541 Revert Series[Any].add(str) #1542

loicdiridollou · 2025-12-10T21:55:39Z

Closes Series[Any] should accept __add__ with strings #1541
Tests added (Please use assert_type() to assert the type of any return value)
If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

pandas-stubs/core/series.pyi

tests/series/test_series.py

…1541_series_any_str

Dr-Irv

I'm fine with this. Would like @cmp0xff to take a look as well.

cmp0xff

I think we still miss a few tests.

I also plan to simplify the tests structure for arithmetic operations, removing the arithmetic subfolder and move everything one level above. Hopefully this will confuse people less in the future.

cmp0xff · 2025-12-13T21:52:26Z

pandas-stubs/core/reshape/pivot.pyi

 def pivot_table(
    data: DataFrame,
-    values: _PivotTableValuesTypes[
+    values: _PivotTableValuesTypes[  # ty: ignore[non-subscriptable]


It's a bit surprising that we now need to ty: ignore's here. Would be great if you could report it to ty.

Proposing an alternative fix in #1547. This is related to astral-sh/ty#1846.

cmp0xff · 2025-12-13T21:57:23Z

pandas-stubs/core/indexes/base.pyi

    def __gt__(self, other: Self | S1) -> np_1darray_bool: ...  # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
    @overload
-    def __add__(self: Index[Never], other: _str) -> Never: ...
+    def __add__(self: Index[Never], other: _str) -> Index[_str]: ...


Please add tests in tests/indexes/arithmetic/test_add.py

cmp0xff · 2025-12-13T21:57:29Z

tests/series/arithmetic/str/test_add.py

+    sr = df[0]
+
+    check(assert_type(sr + "c1", "pd.Series[str]"), pd.Series, str)
+    check(assert_type("c1" + sr, "pd.Series[str]"), pd.Series, str)


series/arithmetic/str/test_add.py is meant to test for known Series[str]. For Series[Any] at type checking, the plan is to use series/arithmetic/test_add.py. Please move this part there.

We also have a left_str = pd.DataFrame({"a": ["1", "2", "3_"]})["a"] defined in that file.

Please also make the undunder methods add and radd work

cmp0xff · 2025-12-13T21:58:17Z

tests/test_timefuncs.py

+from typing import (
+    TypeAlias,
+)


Suggested change

from typing import (

TypeAlias,

)

from typing import TypeAlias

cmp0xff · 2025-12-13T21:58:45Z

tests/indexes/arithmetic/test_add.py

 from typing_extensions import (
-    Never,
    assert_type,
 )


Suggested change

from typing_extensions import (

Never,

assert_type,

)

from typing_extensions import assert_type

cmp0xff · 2025-12-13T21:59:15Z

tests/indexes/arithmetic/test_add.py

    if TYPE_CHECKING_INVALID_USAGE:
-        assert_type(left_i + s, Never)
-        assert_type(s + left_i, Never)
+        # relaxing typing, won't work at runtime though


Suggested change

# relaxing typing, won't work at runtime though

# GH1541 relaxing typing, won't work at runtime though

cmp0xff · 2025-12-14T13:11:56Z

pandas-stubs/core/reshape/pivot.pyi

+        _PivotTableColumnsTypes[  # ty: ignore[non-subscriptable]
+            Hashable  # ty: ignore[invalid-type-arguments]
+        ]


Proposing an alternative fix in #1547. This is related to astral-sh/ty#1846.

cmp0xff · 2025-12-14T13:12:14Z

pandas-stubs/core/reshape/pivot.pyi

+    values: _PivotTableValuesTypes[  # ty: ignore[non-subscriptable]
        Hashable  # ty: ignore[invalid-type-arguments]
    ] = None,
    index: (
-        _PivotTableIndexTypes[Hashable]  # ty: ignore[invalid-type-arguments]
+        _PivotTableIndexTypes[  # ty: ignore[non-subscriptable]
+            Hashable  # ty: ignore[invalid-type-arguments]
+        ]


Proposing an alternative fix in #1547. This is related to astral-sh/ty#1846.

cmp0xff · 2025-12-14T13:12:36Z

pandas-stubs/core/reshape/pivot.pyi

+    values: _PivotTableValuesTypes[  # ty: ignore[non-subscriptable]
        Hashable  # ty: ignore[invalid-type-arguments]
    ] = None,
-    index: _PivotTableIndexTypes[Hashable] = None,  # ty: ignore[invalid-type-arguments]
-    columns: _PivotTableColumnsTypes[
+    index: _PivotTableIndexTypes[  # ty: ignore[non-subscriptable]
+        Hashable  # ty: ignore[invalid-type-arguments]
+    ] = None,
+    columns: _PivotTableColumnsTypes[  # ty: ignore[non-subscriptable]


Proposing an alternative fix in #1547. This is related to astral-sh/ty#1846.

GH1541 Revert Series[Any].__add__(str)

a56a50c

loicdiridollou requested review from Dr-Irv and cmp0xff and removed request for Dr-Irv December 10, 2025 21:55

GH1541 Revert Series[Any].__add__(str)

4aa6173

Dr-Irv requested changes Dec 10, 2025

View reviewed changes

pandas-stubs/core/series.pyi Outdated Show resolved Hide resolved

cmp0xff requested changes Dec 10, 2025

View reviewed changes

tests/series/test_series.py Outdated Show resolved Hide resolved

loicdiridollou added 5 commits December 12, 2025 13:41

GH1541 PR Feedback

3bbe2c1

Merge branch 'main' of github.com:loicdiridollou/pandas-stubs into gh…

9e74866

…1541_series_any_str

GH1541 PR Feedback

e63fe8c

GH1541 PR Feedback

17670b7

GH1541 PR Feedback

4db2db1

loicdiridollou requested review from Dr-Irv and cmp0xff December 12, 2025 19:52

Dr-Irv approved these changes Dec 12, 2025

View reviewed changes

cmp0xff requested changes Dec 13, 2025

View reviewed changes

cmp0xff reviewed Dec 14, 2025

View reviewed changes

	# relaxing typing, won't work at runtime though
	# GH1541 relaxing typing, won't work at runtime though

Uh oh!

GH1541 Revert Series[Any].__add__(str) #1542

Are you sure you want to change the base?

GH1541 Revert Series[Any].__add__(str) #1542

Conversation

loicdiridollou commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

Dr-Irv left a comment

Choose a reason for hiding this comment

Uh oh!

cmp0xff left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmp0xff Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GH1541 Revert Series[Any].add(str) #1542

GH1541 Revert Series[Any].add(str) #1542

cmp0xff Dec 14, 2025 •

edited

Loading