refactor!: remove non-idiomatic From<&String> trait impls #946
+0
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl
approved these changes
Jan 4, 2026
ahl
requested changes
Jan 4, 2026
Collaborator
|
Can you check oxide.rs against this as well please? |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the codegen is outputting both
From<&str>andFrom<&String>implementations. since&Stringauto-dereferences to&strthis is redundant and non-idiomatic.This is in principle a breaking change, but unlikely to have a significant impact on downstream users due to the auto-deferencing (though it's possible some patterns are doing some funny type inference that could be affected by this change)