refactor!: remove non-idiomatic From<&T> for T trait impls #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This breaks assumptions (possibly invalid) in https://github.com/oxidecomputer/oxide.rs |
Contributor
Author
hmm. it would be good to assess the impact on oxide before merging this. i could possibly create a progenitor branch that patches in this typify change, and do the same in oxide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current codegen implements
From<&Self> for Selffor a number of types. This is non-idiomatic since this doesn't match the intended semantics of theFromtrait and implicitly clones the object. It's also redundant with theClonetrait, which is the idiomatic and explicit way to turn a reference into an object.This PR removes this implementation. This is a breaking change for downstream users that are passing references- the caller will now need to explicitly clone