README: change CI platform language #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
approved these changes
Dec 1, 2025
labbott
approved these changes
Dec 1, 2025
pietroalbini
approved these changes
Dec 1, 2025
hawkw
reviewed
Dec 1, 2025
README.mkdn
Outdated
Comment on lines
61
to
62
| inconsistency in linker behavior across platforms, images may not match across | ||
| platforms, so we recommend choosing one. macOS and Illumos are both used as |
Member
There was a problem hiding this comment.
"we recommend choosing one" here feels a bit unclear to me --- choosing one for what? Everyone has chosen a platform in one way or another.
Collaborator
Author
There was a problem hiding this comment.
I've reworded this in an attempt to make the intention clearer.
I realized that this section of the README was sounding like an invitation for potential starter projects, without giving people full context on what the "maintain" part of maintaining a tier-one platform would involve (long term commitment from an experienced engineer). In practice, macOS seems to be the main "other" platform that folks are interested in, but it's also the only one that those of us without Apple hardware can't test locally -- every other OS permits virtualization, which makes macOS a uniquely high support burden. To avoid misleading people, I've adjusted the language to remove the suggestion that we're looking for maintainers. It's not that we _aren't_ looking for maintainers, but more that maintaining a platform will be a longer discussion and not merely a PR.
cbiffle
force-pushed
the
cbiffle/readme-update
branch
from
d1f5cc6 to
e6689c4
Compare
hawkw
approved these changes
Dec 11, 2025
Member
|
It's really funny to me that "README: change CI platform language" is, somehow, failing CI. |
Member
Looks like this was because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that this section of the README was sounding like an invitation for potential starter projects, without giving people full context on what the "maintain" part of maintaining a tier-one platform would involve (long term commitment from an experienced engineer). In practice, macOS seems to be the main "other" platform that folks are interested in, but it's also the only one that those of us without Apple hardware can't test locally -- every other OS permits virtualization, which makes macOS a uniquely high support burden.
To avoid misleading people, I've adjusted the language to remove the suggestion that we're looking for maintainers. It's not that we aren't looking for maintainers, but more that maintaining a platform will be a longer discussion and not merely a PR.