Fix Symfony setDeprecated() arguments#762
Fix Symfony setDeprecated() arguments#762koekaverna wants to merge 1 commit intooverblog:masterfrom koekaverna:master
Conversation
|
@koekaverna I already fixed this in #715 and it was merged into 0.13. It just needs to be applied to master too. I just don't want to have different fixes in different versions. I'm gonna close this PR and open another one with the same patch as in the #715. Or, you could change your PR to match the code in #715 and I approve it. |
|
@murtukov Okay, do it in your way. |
|
@murtukov |
|
@koekaverna the deprecation message says:
The next major version is 1.0 (current master), so we don't need this BC-layer anymore, but need to remove the 'resolver_maps' option instead (as stated in the message). I guess this was the reason I didn't merge it into master. @mcg-web can we remove this deprecated option in the master? GraphQLBundle/src/DependencyInjection/Configuration.php Lines 223 to 227 in 6192522 |
|
@murtukov since next major version is the 1.0 we can safely make this obsolete and remove the configuration. |
|
@koekaverna see #763 |
Since symfony/config 5.1: The signature of method "Symfony\Component\Config\Definition\Builder\NodeDefinition::setDeprecated()" requires 3 arguments: "string $package, string $version, string $message", not defining them is deprecated.