Skip to content

Update reference-ids in OSPS-GV.yaml#464

Open
SecurityCRob wants to merge 2 commits intomainfrom
SecurityCRob-patch-13
Open

Update reference-ids in OSPS-GV.yaml#464
SecurityCRob wants to merge 2 commits intomainfrom
SecurityCRob-patch-13

Conversation

@SecurityCRob
Copy link
Contributor

bsi mappings to gv

bsi mappings to gv

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
@SecurityCRob
Copy link
Contributor Author

SecurityCRob commented Jan 13, 2026

depends on:
#459
#460

related to:
#461
#462
#463
#464
#465
#466
#467

- reference-id: BSI-TR-03185-2
entries:
- reference-id: GV.01
- reference-id: QA.04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel QA.04 is not aligned in this case. Apart from this the remaining reference mappings are consistent. CC: @eddie-knight

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSPS-GV-03 is explicitly called out by BSI when they did their mapping. I would prefer not to adjust their work without their inclusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SecurityCRob I'm curious about that comment... I typically expect the document to contain outgoing mappings. So this is our claim that completing this will give some level of completion to the other control. Any claims they make are independent, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fulfilling osps controls helps support downstream in defending their compliance to auditors. "Compliance" is always in the eyes of the auditor, but the mappings reflect where tasks are aligned or support that defense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "explaining the contribution process" is aligned with "procedures for testing", presuming that the project documents running the tests when contributing code.

I'd suggest there might also be a mapping to BR.01 ("how to build software assets") here, implicitly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #460 (comment)

The BSI mappings are based on the 2025-02-25 version, so they don't "see" any changes or improvements we made either on 2025-10-10 or since then. This means that we can't really directly say that the BSI mappings are "authoritative", because they are pointed at something immutable in the past, rather than the next-published version, which is what these PRs go into.

Copy link
Contributor

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that GV-04 ("code contributors reviewed prior to granting escalated permissions") should have a mapping to GV.02 ("the project's ... MUST be protected against unauthorized actions"), even though it's not in the BSI TR-03185-2 document.

- reference-id: UKSSCOP
entries:
- reference-id: Claim 2.1.1
- reference-id: Claim 2.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add an extra space here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- reference-id: Claim 2.1.1
- reference-id: Claim 2.1.1

- reference-id: BSI-TR-03185-2
entries:
- reference-id: GV.01
- reference-id: QA.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "explaining the contribution process" is aligned with "procedures for testing", presuming that the project documents running the tests when contributing code.

I'd suggest there might also be a mapping to BR.01 ("how to build software assets") here, implicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants